This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Clear screen before test run#36
Merged
glittershark merged 1 commit intourbint:masterfrom Jan 27, 2020
Merged
Conversation
|
|
||
| ```ex | ||
| config :cortex, | ||
| clear_before_running_tests: true |
Contributor
There was a problem hiding this comment.
On the fence about defaulting this to true since it feels like it might be a kind of jarring change. @russmatney @rschmukler thoughts?
Contributor
There was a problem hiding this comment.
I'm mostly indifferent. The readme and changelog document the change well, so, anyone coming from an old version should be able to see what happened easily. Subjectively, I also prefer screen clearing on refresh, so I'd say 
Contributor
|
@axelson mind rebasing? |
axelson
force-pushed
the
clear-screen-before-test-run
branch
from
0dddb97 to
fa15554
Compare
Contributor
Author
|
@glittershark done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on configuration, clear the screen before each test run, defaults to clearing.
Based on #34Fixes #32