Feature: Hide nested flags if hidden tag applied to parent #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This change introduces two new options
InheritHiddenandInheritDeprecatedwhich can be used with theParse*functions to mark all nested flags as eitherhiddenordeprecatedif a parentstructhas been tagged as eitherhiddenordeprecated.For example given the following
structdefinitionand a parser that looks like
you would end up with something like
instead of
Flags: --details-name --details-age --verboseI had initially made this behaviour default behaviour, but refactored to options in order to not break backwards compatibility.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
I don't really like having both
inheritHiddenandhiddenoptions, but I haven't been able to figure out how to combine them. If you have any suggestions please let me know.Testing
New test cases have been added to
parser_test.goto test the behaviourRelease Notes