Repository navigation
feature/Sage - #19
Open
lzw-gif wants to merge 7 commits into
Open
feature/Sage#19lzw-gif wants to merge 7 commits into
lzw-gif wants to merge 7 commits into
Conversation
StSchulze
requested changes
Oct 22, 2026
StSchulze
left a comment
StSchulze
left a comment
Contributor
There was a problem hiding this comment.
One minor change in the uftypes file, otherwise it looks great
Comment on lines
+71
to
+74
| proteomics.params = types.SimpleNamespace() | ||
| proteomics.params.ANY = ".msgfplus.params.ANY" | ||
| proteomics.params.MSGFPLUS_TXT = ".msgfplus_params.txt" | ||
| proteomics.params.SAGE_JSON = ".sage.json" No newline at end of file |
Contributor
There was a problem hiding this comment.
So far, parameter file types were included in the namespace of the engine e.g.
proteomics.dbsearch.MSFRAGGER_TSV = ".msfragger.tsv"
proteomics.dbsearch.MSFRAGGER_PARAMS = ".msfragger.params"
This has the advantage that they are grouped together rather than spread out, and that you avoid having the same name in different categories meaning different file types.
So, I would say, move these parameter file types into the dbsearch section, and then you have one sage_report_json and one sage_params_json
added 2 commits
October 22, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated the Sage unode with resources and tests.