Remove this._destroyed lifecycle guard flag - #5
Merged
Merged
Conversation
EGO reviewer feedback: this is the exact "Bad Practice" pattern the Extension Best Practices Guidelines calls out under Lifecycle and Destruction State — boolean flags like this._destroyed guarding against late-resolving callbacks aren't the correct fix. destroy() already does the right things in the right order (remove sources, disconnect signals, cancel, then super.destroy() last), which is what the guide asks for instead. runCommand()'s CANCELLED passthrough from proc.init() stays — that's unrelated, not a lifecycle flag, and makes cancellation actually propagate instead of being reported as a normal failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_destroyedboolean flag added in a prior teardown-hardening pass — EGO reviewer correctly identified this as the exact "Bad Practice" example the Extension Best Practices Guidelines calls out under Lifecycle and Destruction Statedestroy()already follows the guide's correct order (sources → signals → cancel →super.destroy()last), no flag neededrunCommand()fix that rethrowsCANCELLEDfromproc.init()Test plan
node --check extension.js