feat: fix apply engine delete, add tests, restructure into uv workspace#5
Merged
feat: fix apply engine delete, add tests, restructure into uv workspace#5
Conversation
- Fix delete op to preserve markers per spec §4.2 (was removing them) - Add 44 new apply engine tests (72 total) covering ID-based, pointer, store, and cross-cutting edge cases - Restructure Python packages into aap namespace (PEP 420): - libs/core: aap.core (Rust/PyO3 bindings via maturin) - libs/evals: aap.evals (eval framework via uv_build) - apps/cli: aap.cli (CLI entrypoint via uv_build) - Eliminate .so copy hack — uv sync handles everything
Reduces package from 991 files (3MB) to 20 files (46KB) by excluding Python workspace, specs, scripts, and CI config.
… Protocol (GAP) BREAKING CHANGE: wire markers changed from <aap:target> to <gap:target>, protocol version from aap/0.1 to gap/0.1, Python packages from aap-* to gap-*, and Rust lib name from aap to gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_target_inclusivewhich removed markers + content; switched toresolve_targetfor exclusive range)aap-core(libs/core/) — Rust/PyO3 bindings via maturinaap-evals(libs/evals/) — Eval framework via uv_buildaap-cli(apps/cli/) — CLI entrypoint via uv_buildjustfile— remove.socopy hack andcd evalsprefixesTest plan
cargo test— all 72 Rust tests passuv sync— workspace resolves, maturin builds coreuv run aap-evals run— experiment 002 completes successfully (92.6% output token savings)