Skip to content

Harden outbound URL handling#63

Merged
us merged 2 commits into
mainfrom
codex/opencore-outbound-hardening
May 30, 2026
Merged

Harden outbound URL handling#63
us merged 2 commits into
mainfrom
codex/opencore-outbound-hardening

Conversation

@us
Copy link
Copy Markdown
Owner

@us us commented May 29, 2026

Summary

  • add DNS-resolved URL safety checks for REST/MCP scrape, crawl, map, search enrichment, and crawl discovery paths
  • keep a session-lifetime CDP Fetch guard in crw-browse so browser navigations, redirects, clicks, and script-triggered requests are revalidated before continuing
  • restrict screenshot file writes to an explicit screenshot directory with single-file relative paths and create-new semantics

Validation

  • pre-commit hook: cargo fmt, clippy, and workspace tests
  • cargo test -p crw-browse --lib
  • cargo test -p crw-core url_safety --lib
  • cargo check -p crw-server
  • cargo check -p crw-cli

Notes

  • DNS preflight cannot prove the browser/socket connect IP against DNS rebinding by itself; managed deployments should still enforce network-layer private/link-local egress denial.

closes #61

@us us marked this pull request as ready for review May 30, 2026 11:17
Copilot AI review requested due to automatic review settings May 30, 2026 11:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@us us force-pushed the codex/opencore-outbound-hardening branch from 7130cf1 to b08ead2 Compare May 30, 2026 12:33
@us us merged commit a3c2076 into main May 30, 2026
2 checks passed
@us us deleted the codex/opencore-outbound-hardening branch May 30, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: apply SSRF protection and path validation to browse mode

2 participants