Skip to content

Support for Conan 2 setups#7

Draft
nullbytepl wants to merge 2 commits into
masterfrom
clang-dev
Draft

Support for Conan 2 setups#7
nullbytepl wants to merge 2 commits into
masterfrom
clang-dev

Conversation

@nullbytepl
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread pydevops/utils.py
def is_version_at_least(minimum_version):
version_parts = [int(part) for part in version.__version__.split('.')]
minimum_parts = [int(part) for part in minimum_version.split('.')]
for v, m in zip(version_parts, minimum_parts):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify that to:

def is_version_at_least(minimum_version):
    version_parts = [int(part) for part in version.__version__.split('.')]
    minimum_parts = [int(part) for part in minimum_version.split('.')]
    return version_parts >= minimum_parts

or even:

from packaging import version

def is_version_at_least(minimum_version):
    return version.parse(version.__version__) >= version.parse(minimum_version)

@nullbytepl
Copy link
Copy Markdown
Collaborator Author

@pjarosik RFC: Since this is a massive change, maybe we should bump the version to 1.0.0 after this, and perhaps even move from devops.py being the file being read to devops2.py or something, so we could show an user-readable error by simply putting something in devops.py, then put the actual config in devops2.py. After that, we could use is_version_at_least or similar to check for updates beyond that point.

I have a few ideas of useful stuff for a hypothetical 1.0.0, if we could force everyone to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants