Support for Conan 2 setups#7
Draft
nullbytepl wants to merge 2 commits into
Draft
Conversation
pjarosik
reviewed
Jun 2, 2026
| def is_version_at_least(minimum_version): | ||
| version_parts = [int(part) for part in version.__version__.split('.')] | ||
| minimum_parts = [int(part) for part in minimum_version.split('.')] | ||
| for v, m in zip(version_parts, minimum_parts): |
Collaborator
There was a problem hiding this comment.
Please simplify that to:
def is_version_at_least(minimum_version):
version_parts = [int(part) for part in version.__version__.split('.')]
minimum_parts = [int(part) for part in minimum_version.split('.')]
return version_parts >= minimum_parts
or even:
from packaging import version
def is_version_at_least(minimum_version):
return version.parse(version.__version__) >= version.parse(minimum_version)
Collaborator
Author
|
@pjarosik RFC: Since this is a massive change, maybe we should bump the version to 1.0.0 after this, and perhaps even move from I have a few ideas of useful stuff for a hypothetical 1.0.0, if we could force everyone to upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.