[webdevayo]

Closes #457

What

make attest now checks for the stellar CLI first (new check-stellar
prerequisite) and, if it is missing, fails immediately with a message that
names the tool and links the install docs.

Before

make attest without stellar failed with a shell command not found
partway through the recipe, after go build and the attestation parameters
had already run.

After

error: the 'stellar' CLI was not found on your PATH. Install it from
https://developers.stellar.org/docs/build/smart-contracts/getting-started/setup
and re-run 'make attest'.
make: *** [Makefile:143: check-stellar] Error 1

The guard runs before go build and before the ASSET usage check, and the
message goes to stderr.

Testing

• With stellar missing from PATH (with and without ASSET): the error above,
  make exits non-zero, and no later step runs.
• With a stub stellar on PATH: make -n attest prints the original recipe
  unchanged.

Scope

Limited to the guard, per the issue's out-of-scope note.

[drips-wave]

@webdevayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[mergekeeper]

MergeKeeper review

Scope: in scope for linked issue #457.
Verdict: clean

This PR adds a check-stellar prerequisite to the make attest target in the Makefile, ensuring that a clear error message with installation instructions is displayed if the stellar CLI is missing from the PATH. The implementation correctly addresses issue #457 and stays within scope.

Reviewed commit: 0e22362b1ac7843cf04645f95019b0300040b363.
CI and merge eligibility are checked separately.

[mergekeeper]

MergeKeeper merge status

Status: blocked
PR state: open
Mergeability: conflicts / not mergeable
Checked commit: 0e22362b1ac7843cf04645f95019b0300040b363.

Reason: One or more required CI checks failed.

Failing checks:

• govulncheck - view details

Next steps:

1. Open the failing check details above and fix the reported error.
2. Run the same checks locally where possible.
3. Commit and push the fix.
4. MergeKeeper will automatically re-review the updated PR.

[samjay8]

Thanks. main now has a check-stellar-cli-version target that make attest relies on to fail fast when the Stellar CLI is missing or the wrong version, so this change is covered already and the branch conflicts with main.

If you see a case the current check misses, please rebase onto main and adjust the existing target rather than adding a second guard.

[mergekeeper]

Needs changes

The PR adds a helpful check-stellar rule to the Makefile, but it fails to wire it up as a prerequisite to the attest target so the guard never actually executes.

---

Blocking

Makefile:176

Problem: The check-stellar rule is defined in the Makefile but is not added as a prerequisite to the attest target, meaning running make attest will not trigger the check.

Suggested fix: Locate the attest target in the Makefile and add check-stellar as a prerequisite (e.g., attest: check-stellar ...).

Prompt for an AI coding agent

In Makefile, add `check-stellar` as a prerequisite to the `attest` target so that running `make attest` executes the guard check before proceeding.

---

Reviewed commit: 2e256666e51bc0dca387da10a2ba444ce924df12.

[mergekeeper]

Needs changes

The PR adds a helpful check-stellar rule to the Makefile, but it fails to wire it up as a prerequisite to the attest target so the guard never actually executes.

---

Blocking

Makefile:176

Problem: The check-stellar rule is defined in the Makefile but is not added as a prerequisite to the attest target, meaning running make attest will not trigger the check.

Suggested fix: Locate the attest target in the Makefile and add check-stellar as a prerequisite (e.g., attest: check-stellar ...).

Prompt for an AI coding agent

In Makefile, add `check-stellar` as a prerequisite to the `attest` target so that running `make attest` executes the guard check before proceeding.

---

Reviewed commit: 2e256666e51bc0dca387da10a2ba444ce924df12.

[webdevayo]

@samjay8 All resolved please merge

lgtm