Repository navigation
a11y: focus ring on the reply card; aria-controls names the listbox - #385
Open
LetMeSleep8h wants to merge 1 commit into
Open
LetMeSleep8h wants to merge 1 commit into
LetMeSleep8h wants to merge 1 commit into
Conversation
Tabbing into the reply box showed nothing: the card gains a focus-within ring (border-border-focus-ring token), and while the / command list is open the textarea's aria-controls now points at the listbox's own id instead of the heading's. Fixes useagenthq#328
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328, exactly the three steps the issue lays out:
frontend/components/chat/composer.tsx) gainsfocus-within:border-border-focus-ring focus-within:ring-border-focus-ring focus-within:ring-1— tabbing to the textarea now draws a visible ring around the card (the textarea itself keeps itsoutline-none focus-visible:ring-0, since the card is the focus indicator now).role="listbox"element inslash-command.tsxgetsid="slashcmd-listbox", and the textarea'saria-controlspoints at it instead of theslashcmd-labelheading's id — a screen reader now hears that the combobox controls the list, not a paragraph.slash-command-listbox.test.tsxpins the listbox id.bun test componentsgreen (all existing suites + the new one).Need help on this PR? Tag
@codesmith-botwith what you need.