Skip to content

Show a focus ring on the Workspace file tabs - #388

Merged
abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-334
Oct 27, 2026
Merged

abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-334

Conversation

@tianxingjian2406

@tianxingjian2406 tianxingjian2406 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #334

What changed

  • The Workspace tab buttons and the "What edits are preserved" toggle removed the browser outline and added nothing back. Keyboard users could not see where they are. All three controls now carry the same focus ring as the rest of the thread: focus-visible:ring-2 focus-visible:ring-border-focus-ring.
  • The tab close button gets the same ring.

Testing

  • New workspace-pane.test.tsx mounts the tab strip and asserts that the tab button and the close button render the focus ring. It fails without the class change and passes with it.
  • bun run typecheck, bun test components app lib, and bun run lint run clean. The single failing test on Windows is the known ghostty-web WASM failure. It also fails on unmodified main.
  • Manual check: Tab through the Workspace tab strip. Every tab, the close button, and the "What edits are preserved" toggle show a ring when focused.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tianxingjian2406

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it.

@tianxingjian2406

tianxingjian2406 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Screenshots from the running app (keyboard focus, /lab/workspace):

Before — no visible focus on the tab or its close button:

before: workspace file tab focused, no ring
before: tab close button focused, no ring

After — ring on both:

after: workspace file tab focused with ring
after: tab close button focused with ring

How I tested it: I ran the frontend locally (bun run dev), opened the Workspace lab pane, pressed Tab until the file tab had focus, then Tab again to the close button, and captured each state. frontend/components/chat/workspace-pane.test.tsx asserts the ring classes. The full suite passes (only the known ghostty-web baseline failure). The "What edits are preserved" summary uses the same focus-ring utility, but the lab pane does not mount that editor surface, so the screenshots cover the tab strip.

@abhishekgahlot2
abhishekgahlot2 merged commit a3f69ea into useagenthq:main Oct 27, 2026
1 of 2 checks passed
@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Merged, thanks @tianxingjian2406!

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show a focus ring on Workspace file tabs

3 participants