Repository navigation
Show a focus ring on the Workspace file tabs - #388
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it. |
|
Screenshots from the running app (keyboard focus, Before — no visible focus on the tab or its close button: After — ring on both: How I tested it: I ran the frontend locally ( |
|
Merged, thanks @tianxingjian2406! |




Fixes #334
What changed
focus-visible:ring-2 focus-visible:ring-border-focus-ring.Testing
workspace-pane.test.tsxmounts the tab strip and asserts that the tab button and the close button render the focus ring. It fails without the class change and passes with it.bun run typecheck,bun test components app lib, andbun run lintrun clean. The single failing test on Windows is the known ghostty-web WASM failure. It also fails on unmodified main.Need help on this PR? Tag
@codesmith-botwith what you need.