Skip to content

Merge the two elapsed timers into one component - #392

Merged
abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-331
Oct 27, 2026
Merged

abhishekgahlot2 merged 1 commit into
useagenthq:mainfrom
tianxingjian2406:fix/issue-331

Conversation

@tianxingjian2406

@tianxingjian2406 tianxingjian2406 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #331

What changed

  • The thread kept two identical self-ticking timers: ElapsedTimer in background-status-pill.tsx and a private WorkingTimer in working-indicator.tsx. A fix to one never reached the other.
  • There is now one component in elapsed-timer.tsx. The background status pill, the working indicator, and running-footer.tsx all import it.
  • No behavior change. Same text-node updates, same one-second cadence.

Testing

  • New elapsed-timer.test.tsx asserts that the timer renders its elapsed text in tabular figures.
  • bun run typecheck, bun test components app lib, and bun run lint run clean (the known ghostty-web WASM baseline failure aside).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 16:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tianxingjian2406

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it.

@tianxingjian2406

tianxingjian2406 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Screenshots from the running app:

Running footer timer — before / after:

before: running footer timer
after: running footer timer

Working line timer — before / after:

before: working line timer
after: working line timer

The refactor keeps the behaviour: both places render the same self-ticking elapsed label, so the captures match before and after. The working line reads "Working for 50s · Editing gateway/routes.ts" in both.

How I tested it: I ran the app and captured the two timer surfaces (background-status-pill on the session lab page and the real WorkingIndicator). bun test components passes except the known ghostty-web baseline failure. Typecheck and lint are clean.

@abhishekgahlot2
abhishekgahlot2 merged commit 4419d48 into useagenthq:main Oct 27, 2026
1 of 2 checks passed
@abhishekgahlot2

Copy link
Copy Markdown
Contributor

Merged, thanks @tianxingjian2406! One timer instead of two is much tidier.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge the two identical elapsed-time timers in the thread

3 participants