Repository navigation
Merge the two elapsed timers into one component - #392
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks for this. Before we can merge, please add a before/after screenshot or a short screen recording of the change working in the running app (the issue asks for one), plus a line on how you tested it. |
|
Screenshots from the running app: Running footer timer — before / after: Working line timer — before / after: The refactor keeps the behaviour: both places render the same self-ticking elapsed label, so the captures match before and after. The working line reads "Working for 50s · Editing gateway/routes.ts" in both. How I tested it: I ran the app and captured the two timer surfaces ( |
|
Merged, thanks @tianxingjian2406! One timer instead of two is much tidier. |




Fixes #331
What changed
elapsed-timer.tsx. The background status pill, the working indicator, and running-footer.tsx all import it.Testing
elapsed-timer.test.tsxasserts that the timer renders its elapsed text in tabular figures.bun run typecheck,bun test components app lib, andbun run lintrun clean (the known ghostty-web WASM baseline failure aside).Need help on this PR? Tag
@codesmith-botwith what you need.