Conversation
…dd corresponding test cases
juiwenchen
reviewed
Dec 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 89.39% 89.41% +0.02%
==========================================
Files 29 29
Lines 2414 2419 +5
Branches 290 290
==========================================
+ Hits 2158 2163 +5
Misses 161 161
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
juiwenchen
reviewed
Dec 11, 2025
| ), | ||
| ], | ||
| ) | ||
| def test_oneline_parser_space_separator( |
Contributor
There was a problem hiding this comment.
Greate! Could you add the following test case? so that we know escaping separator works? (I tested it works)
# Title contain spaces
(
f"@ Title\ escape\ space ID_456{UNIX_NEWLINE}",
{
"title": "Title escape space",
"id": "ID_456",
"type": "impl",
"start_column": 1,
"end_column": 30,
},
),
juiwenchen
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix leading and trailing space handling in oneline_parser and add corresponding test cases
closes #51