Skip to content

🔧 Allow template global_options#1454

Merged
chrisjsewell merged 3 commits into
masterfrom
global-template
May 14, 2025
Merged

🔧 Allow template global_options#1454
chrisjsewell merged 3 commits into
masterfrom
global-template

Conversation

@chrisjsewell
Copy link
Copy Markdown
Member

No description provided.

@ubmarco ubmarco self-requested a review May 14, 2025 08:34
Copy link
Copy Markdown
Member

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
The field collapse should also be allowed to be set via needs_global_options.

@chrisjsewell
Copy link
Copy Markdown
Member Author

The field collapse should also be allowed to be set via needs_global_options.

we've already talked about this, booleans do NOT work in the current code logic, this requires a bigger fix

@chrisjsewell chrisjsewell merged commit bc1a52d into master May 14, 2025
17 checks passed
@chrisjsewell chrisjsewell deleted the global-template branch May 14, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants