Skip to content

ci: use prod build for playwright tests - #8674

Open
prateek-bruno wants to merge 1 commit into
usebruno:mainfrom
prateek-bruno:ci/use-prod-build-for-ci
Open

ci: use prod build for playwright tests#8674
prateek-bruno wants to merge 1 commit into
usebruno:mainfrom
prateek-bruno:ci/use-prod-build-for-ci

Conversation

@prateek-bruno

@prateek-bruno prateek-bruno commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Description

Switching to a prod build for CI helps in:

  • Reducing flakiness in some windows tests which fail on timeout
  • Faster test execution (12m-20m less observed on windows tests)

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Tests
    • End-to-end tests can now run against the production web build when configured.
    • Improved test-runner handling for CI environments and parallel Electron test execution.
    • Test workflows now consistently use the appropriate web server mode across supported environments.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: af1d157e-f310-4018-a671-338f8aba61de

📥 Commits

Reviewing files that changed from the base of the PR and between 6759656 and fa9c97b.

📒 Files selected for processing (2)
  • .github/actions/tests/run-e2e-tests/action.yml
  • playwright.config.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • playwright.config.ts
  • .github/actions/tests/run-e2e-tests/action.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Playwright E2E CI steps now set E2E_WEB_SERVER=build. The Playwright configuration uses that value to build Bruno and serve it with npm run preview; otherwise, it retains npm run dev:web.

Changes

E2E production server

Layer / File(s) Summary
Configure production E2E server
.github/actions/tests/run-e2e-tests/action.yml, playwright.config.ts
CI branches set E2E_WEB_SERVER=build. Playwright then runs the Bruno build followed by npm run preview, or uses npm run dev:web for other values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fa9c9

This is a localized CI configuration change to run Playwright tests against a production build; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: bijin-bruno

Poem

Builds run bright,
Previews serve the night,
Playwright checks the way,
Bruno ships today.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using a production build for Playwright tests in CI.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sid-bruno
sid-bruno marked this pull request as draft July 21, 2026 06:48
@sid-bruno

Copy link
Copy Markdown
Collaborator

Converted to draft so we can validate this after v4 is released

@prateek-bruno
prateek-bruno force-pushed the ci/use-prod-build-for-ci branch from c1c3317 to fa9c97b Compare August 21, 2026 19:21
@prateek-bruno
prateek-bruno marked this pull request as ready for review August 21, 2026 19:21
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@prateek-bruno prateek-bruno changed the title ci: use prod build for ci ci: use prod build for playwright tests Aug 21, 2026
Co-authored-by: Prateek Sunal
<41370460+prateekmedia@users.noreply.github.com>
@prateek-bruno
prateek-bruno force-pushed the ci/use-prod-build-for-ci branch from fa9c97b to a6e4464 Compare August 24, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants