Monitor cleanup operations - #2188
Draft
gsaudade99 wants to merge 10 commits into
Draft
Conversation
gsaudade99
marked this pull request as ready for review
July 29, 2026 15:10
gsaudade99
changed the title
bgruening
reviewed
Jul 30, 2026
bgruening
reviewed
Jul 30, 2026
bgruening
left a comment
bgruening
left a comment
Member
There was a problem hiding this comment.
Looks good in principle, I'm just wondering the err files should not contain an error message already that you can reuse.
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Contributor
Author
There are many warnings in this files, but I guess I could maybe grep for I think my concern here, is more if the cleanup script gets stuck. I will rethink a better solution |
gsaudade99
marked this pull request as draft
July 31, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a critical point here. Ideally I would run the script directly in telegraf, but I think is better to keep users telegraf and galaxy separated.
For this, I changed the script to write a
galaxy_cleanup_status_filewith weather the cleanup script was a success or not based on the exit status of the python cleanup script.Closes https://github.com/usegalaxy-eu/issues/issues/995.