fix: support Windows PowerShell 5.1 parsing - #5
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves Windows PowerShell 5.1 compatibility by removing Unicode em dashes from the setup script’s text/comments and by adding a Makefile check that validates parsing under Windows PowerShell 5.1.
Changes:
- Replaced Unicode em dashes (
—) with ASCII hyphens (-) insetup.ps1user-facing output and comments. - Extended
make checkto additionally parse all.ps1files usingpowershell.exe(Windows PowerShell 5.1), alongside the existingpwsh-based checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
setup.ps1 |
Replaces Unicode em dashes with ASCII hyphens to avoid PowerShell 5.1 parsing/encoding pitfalls. |
Makefile |
Adds a Windows PowerShell 5.1 parse pass to make check to catch Desktop-edition parser incompatibilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.