Main sync: X02 S6 corpus rev 2 (observation-envelope canonical shape + dash goldens) - #10
Merged
Merged
Conversation
…int at add, preserved by rename/update/re-add) servers.yml records gain an id (srv-<16hex>, crypto/rand), minted once at server add for genuinely new entries only. RenameServer/UpdateServer carry the whole entry so preservation is structural. AddServer's upsert preserves the existing id — and deliberately leaves legacy id-less entries id-less: minting there would silently re-key dash's name-hash fallback identity underneath live references (X02 ADR §1.3's silent-re-key prohibition). Legacy servers keep working through dash's fallback; adoption stays the consumer's explicit decision. Pinned: mint shape + uniqueness, re-add preserves id, legacy stays id-less on upsert, rename/update preserve id byte-identical.
…e §2.4 canonical shape + dash-generated goldens (corpus rev 2)
Schema now carries the adopted D13 form (resource{type,id}, last_success_at,
collected_at, freshness tri-state fresh|stale|unknown, error, source,
last_known{server,host,apps}); the S2 skeleton's status-enum draft is
corrected before any consumer existed. Fixtures generated from teploy-dash's
real constructors via its contracts golden test
(teploy-dash internal/server/observation_contracts_test.go): fresh, stale,
unknown-unreachable, and unreachable-last-known (the rule-3 merge — a failed
probe keeps the previous payload by id; freshness is last-success age, never
the probe outcome — pinned stale-reading in the same fixture).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror sync from Forgejo main (f305c45..c413685). Same commits, same tree.