Use minimal configuration for fresh Ship installations - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh installations currently merge their destination overlay with the maintainer's production configuration, inheriting unrelated host mounts and preview settings. The installer now stages the minimal self-hosted configuration with the built image inputs, applies the destination overlay there, and removes the private temporary context on exit. The source checkout is unchanged and the deployed version retains its source commit identifier.
Validation: lint passed; 1,411 runtime tests and 101 script tests passed (one existing skip). A staging test checks every Dockerfile COPY input, exact minimal-base selection, exclusion of operator files, and refusal of a nonempty destination. Shell syntax checks passed. An isolated installation rehearsal is running; clean-machine installation timing remains unverified. Production remains frozen for the ongoing baseline.