Repository navigation
S07 part 1: plan grounding check (observe-only, flag off) - #53
Merged
Merged
Conversation
Pure module plus git-backed adapter that checks whether the files, symbols, package scripts and make targets a plan names exist in the committed tree at a stated revision. Three-valued (grounded / ungrounded / unchecked, plus proposed for things the plan says it creates). Advisory only; gated by SHIP_PLAN_GROUNDING (default off); not wired into any run or route. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VqsBNqvaWezf1DwQrAnVgX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
src/plan-grounding.ts: pure extractor and judge plus a git-backed adapter. It checks whether the files, symbols, package.json scripts and make targets a plan names exist in the committed tree at a stated revision (git ls-tree,git show,git grepagainst the commit, so the working tree is never consulted).grounded,ungrounded,unchecked(could not look) orproposed(the plan says it creates it).uncheckedis never counted as a pass.unchecked.SHIP_PLAN_GROUNDING=on|1|true(default off). Nothing is wired into any run, route or durable step, and storage is unchanged. No model is called.src/plan-grounding.test.ts: 15 tests over real temp git repos read through a realLocalExecutor.Checks
pnpm run lintis clean. Root suite is 1998 pass, 0 fail (1983 before plus 15 new), run vianode --test --experimental-test-isolation=none "dist/**/*.test.js". After merging main I re-ran lint, build and the new test file only.Not verified / still open
unchecked(nothing is run).🤖 Generated with Claude Code
https://claude.ai/code/session_01VqsBNqvaWezf1DwQrAnVgX
Generated by Claude Code