Fixed a NullPointerException that would occur in Neovim#996
Merged
DavyLandman merged 2 commits intousethesource:mainfrom Mar 2, 2026
Merged
Fixed a NullPointerException that would occur in Neovim#996DavyLandman merged 2 commits intousethesource:mainfrom
NullPointerException that would occur in Neovim#996DavyLandman merged 2 commits intousethesource:mainfrom
Conversation
DavyLandman
approved these changes
Mar 1, 2026
| fileOperationCapabilities.setDidCreate(whichFiles); | ||
| } | ||
| if (clientCapabilities.getFileOperations().getDidRename().booleanValue()) { | ||
| operations = clientCapabilities.getFileOperations(); |
Member
There was a problem hiding this comment.
I think we don't need to re-request the getFileOperations, yes it's the more correct refactoring, but it doesn't make sense.
Contributor
Author
There was a problem hiding this comment.
I removed the 2 unnecessary getFileOperations() calls.
DavyLandman
approved these changes
Mar 2, 2026
toinehartman
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #989.