Repository navigation
fix(turbopack): honor IE targets in runtime output - #204
Draft
fireairforce wants to merge 2 commits into
Draft
fireairforce wants to merge 2 commits into
fireairforce wants to merge 2 commits into
Conversation
Tests in progressCommit: 0372d99 |
This was referenced Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE targets were treated as supporting arrows, allowing the library minifier to emit syntax outside ES5 and skip the final legacy emission. Treat IE as lacking arrow support. Avoid eager runtime dependencies on URL, Array.prototype.includes and Symbol.iterator when importing CommonJS modules.
Dynamic CommonJS star re-exports also failed to initialize without Proxy. Add a getter-based fallback that snapshots the original CommonJS enumerable export names while keeping values live, preserving static exports, the first source's precedence and getter receivers. Track raw CommonJS sources only when Proxy is unavailable so namespace conversion does not accidentally re-export hidden properties. The existing Proxy path is retained.
Validated through Pack's 13 runtime snapshot cases, including a minified IE11 UMD parsed in full as ES5 and executed in browser/CommonJS VM contexts without Symbol, URL or Proxy. The fixture exercises dynamic CommonJS re-exports, hidden/inherited properties, static precedence, live getters and function/string exports. Real Father/Webpack differential checks pass for both Pack compression modes without Proxy, including environments without Symbol, Reflect, URL or Array.prototype.includes, covering source priority, deleted/late keys, descriptors, receiver behavior and early cyclic references. Also checked a complete component-library UMD with ES5 parsing, cargo fmt, and clippy. Runtime TypeScript checks report the same existing diagnostics as the base revision. Actual IE11 browser execution has not been tested; this is not a claim of full bundler equivalence in all environments.
Parent integration and regression fixture: utooland/utoo#3412. Father configuration forwarding: umijs/father#873.