Repository navigation
test(ecosystem): cover EVJS H5 SWC runtime helpers - #11
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named RegExp lowering requires
@swc/helpers/_/_wrap_reg_exp, which is absent from the helpers dependency shipped by@utoo/pack@1.5.35. Add anevjs-h5ecosystem suite to exercise this compatibility contract through public EVJS, alongside the dependency fix in utooland/utoo#3433.The suite prepares a disposable MPA workspace targeting Android 5 / iOS 8 with
marked@17.0.5, builds EVJS and the production app, and checks Markdown rendering, named groups, backreferences, replacements, and page errors in Chromium. It checks the underlying RegExp source to prove lowering occurred. A separate assertion resolves the required helper from the candidate Pack's dependency context, because newer helpers hoisted by other EVJS development tools can otherwise mask an incompatible candidate. The fixture does not override helpers or inject resolver aliases.Register the suite in the manual selector and
allmatrix, preserving the existing candidate verification and stale-install cleanup. Android/iOS versions are compilation targets; browser execution uses Chromium.Validation:
ut install,ut test(48 passed),ut lint,ut check:workflow, andgit diff --checkpassed; the new suite's dry-run has the expected preparation/install/build/test order.353443dc7f9f, published Pack1.5.35fails the candidate helper-export assertion. Its browser test passes under the current hoisted dependency layout, demonstrating why the additional assertion is necessary.@swc/helperschanged from0.5.15to0.5.23. All other package files and native dependencies remain unchanged. This local macOS ARM64 validation reuses the published native binary; it is not a fresh Rust build.