Repository navigation
refactor(pack): remove emotion react transform - #2630
Conversation
Summary of ChangesHello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refactoring the pack-core crate by removing the emotion react transform. This change is intended to streamline the build process and improve overall performance, as the transform is no longer relevant. The updates include modifications to the crate's dependencies, context, configuration, schema, and associated documentation. Highlights
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
5ce62d2 to
0e47c26
Compare
There was a problem hiding this comment.
Code Review
This pull request effectively removes the Emotion transform from the codebase. The changes span across Rust crates, TypeScript packages, and configuration files, consistently removing feature flags, code implementations, type definitions, and documentation related to Emotion. The changes are well-executed and align with the PR's stated goal. I've pointed out one area for improvement regarding unrelated changes in the JSON schema file, which would be better handled in a separate pull request to maintain focus.
0e47c26 to
c1552d6
Compare
📊 Performance Benchmark Report (with-antd)Utoopack Performance ReportReport ID: Executive SummaryKey Findings
Workload Distribution by Tier
Parallelization AnalysisThread Utilization
Assessment: With 5 working threads, achieving 3.1x parallelism indicates significant loss of potential parallelism. Top 20 Tasks by Total Duration
Deep Dive by TierTier 1: Runtime & Resolution (P0)Focus: Task scheduling and dependency resolution.
Potential P0 Issues:
Tier 2: Physical & Resource Barriers (P1)Focus: Hardware utilization, I/O, and heavy monoliths.
Tier 3: Architecture & Asset Pipeline (P2-P3)Focus: Global state and transformation pipeline.
Duration Distribution
Diagnostic Signal Summary
Action Items (P0-P4)
Report generated by Utoopack Performance Analysis Agent on 2026-02-25 |
Summary
Since #2595 (comment) emotion jsx transform has been deleted.
This removes the events as they're no longer relevant and it's not worth slowing down dev/build for them.
Test Plan