Skip to content

perf(pm): drop redundant in-memory versions_info fill on 200 path #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elrrrrrrr merged 1 commit into from
Apr 30, 2026
Merged

perf(pm): drop redundant in-memory versions_info fill on 200 path #2879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions crates/ruborist/src/service/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,15 @@ impl UnifiedRegistry {
.map_err(RegistryError)?
{
manifest::FetchManifestResult::Ok(manifest, new_etag) => {
// Build a `VersionsInfo` strictly for the disk-persist
// task. We do NOT also fill the in-memory
// `versions_info` cache slot on the 200 path: readers
// (`resolve_via_full_manifest::Full`) now go through
// `VersionsRef::from(&Arc<FullManifest>)` for this
// case, so the `full_manifests` slot is the single
// source of truth in memory. The `versions_info` slot
// is reserved for the 304 path (or disk-loaded warm
// cache from a previous run).
let versions_info = Arc::new(VersionsInfo {
versions: Versions {
version_list: manifest.versions.clone(),
Expand All @@ -255,8 +264,6 @@ impl UnifiedRegistry {
});
self.cache
.set_full_manifest(name.to_string(), Arc::new(manifest));
self.cache
.set_versions(name.to_string(), Arc::clone(&versions_info));
// Fire-and-forget: store may spawn its own task.
self.store.store_versions(name, versions_info);
}
Expand All @@ -277,6 +284,10 @@ impl UnifiedRegistry {
.await
.map_err(RegistryError)?;

// Same shape as the 200 branch: only the
// canonical `full_manifests` slot is filled in
// memory; the disk-persist task gets its own
// `Arc<VersionsInfo>`.
let versions_info = Arc::new(VersionsInfo {
versions: Versions {
version_list: manifest.versions.clone(),
Expand All @@ -287,8 +298,6 @@ impl UnifiedRegistry {
});
self.cache
.set_full_manifest(name.to_string(), Arc::new(manifest));
self.cache
.set_versions(name.to_string(), Arc::clone(&versions_info));
self.store.store_versions(name, versions_info);
}
}
Expand Down
Loading