Skip to content

fix(pack): include library runtime config in entry content hashes #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fireairforce merged 2 commits into from
Oct 28, 2026
Merged

fix(pack): include library runtime config in entry content hashes #3429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0360829
fix(pack): include library runtime config in entry content hashes
fireairforce Oct 28, 2026
555ae5c
test(pack): refresh library entry hash snapshots
fireairforce Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions crates/pack-core/src/library/chunking_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,16 +394,23 @@ impl LibraryChunkingContext {
let chunk_content_hash =
self.ecmascript_chunk_content_hash(ecmascript_chunk).await?;
let other_chunks = other_chunks.await?;
let content_hash = if other_chunks.is_empty() {
chunk_content_hash.to_string()
} else {
let mut hasher = Xxh3Hash64Hasher::new();
hasher.write_value(chunk_content_hash.as_str());
for asset in other_chunks.iter() {
hasher.write_value(asset.path().await?.path.as_str());
}
encode_hex(hasher.finish())
};
// The entry wrapper publishes the library namespace and export path.
// Include its configuration even when there are no other chunks, so
// changed exports cannot reuse a URL that still serves an old wrapper.
// Shared non-entry chunks retain their module-only content hashes.
let mut hasher = Xxh3Hash64Hasher::new();
hasher.write_value("library-evaluate-v1");
hasher.write_value(chunk_content_hash.as_str());
hasher.write_ref(&this.runtime_root);
hasher.write_ref(&this.runtime_export);
hasher.write_value(this.is_node_platform);
hasher.write_value(this.output_root_to_root_path.as_str());
hasher.write_ref(&this.asset_base_path);
hasher.write_ref(&this.source_maps_type);
for asset in other_chunks.iter() {
hasher.write_value(asset.path().await?.path.as_str());
}
let content_hash = encode_hex(hasher.finish());
filename = replace_content_hash_placeholder(&filename, &content_hash);
};
AssetIdent::from_path(root.join(&filename)?)
Expand Down
4 changes: 2 additions & 2 deletions .../output/server/entries/server.5d80c3de.js → .../output/server/entries/server.882b3b69.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ if (typeof exports === 'object' && typeof module === 'object') {
for(var i in a) globalThis[i] = a[i];
}
})([
["entries/server.5d80c3de.js",
["entries/server.882b3b69.js",

"[project]/basic/multi_server_entries/input/server.ts [server] (ecmascript)", ((__turbopack_context__) => {
"use strict";
Expand All @@ -972,5 +972,5 @@ var __TURBOPACK__imported__module__$5b$project$5d2f$basic$2f$multi_server_entrie
console.log("server runtime", __TURBOPACK__imported__module__$5b$project$5d2f$basic$2f$multi_server_entries$2f$input$2f$shared$2e$ts__$5b$server$5d$__$28$ecmascript$29$__["shared"]);
}),
],
["entries/server.5d80c3de.js", {"otherChunks":["chunks/server-shared.fbcd5f75.js","chunks/server-shared-0-1.1b081f62.js"],"runtimeModuleIds":["[project]/basic/multi_server_entries/input/server.ts [server] (ecmascript)"]}],
["entries/server.882b3b69.js", {"otherChunks":["chunks/server-shared.fbcd5f75.js","chunks/server-shared-0-1.1b081f62.js"],"runtimeModuleIds":["[project]/basic/multi_server_entries/input/server.ts [server] (ecmascript)"]}],
]);
42 changes: 21 additions & 21 deletions crates/pack-tests/tests/snapshot/basic/multi_server_entries/output/server/stats.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
"name": "detail-server",
"chunks": [
"chunks/server-shared.fbcd5f75.js",
"entries/detail-server.5d841f26.js"
"entries/detail-server.b1ab83f5.js"
],
"assets": [
{
"name": "chunks/server-shared.fbcd5f75.js"
},
{
"name": "entries/detail-server.5d841f26.js"
"name": "entries/detail-server.b1ab83f5.js"
}
]
},
Expand All @@ -20,7 +20,7 @@
"chunks": [
"chunks/server-shared-0-1.1b081f62.js",
"chunks/server-shared.fbcd5f75.js",
"entries/index-server.5c83aa4e.js"
"entries/index-server.f88edfa9.js"
],
"assets": [
{
Expand All @@ -30,7 +30,7 @@
"name": "chunks/server-shared.fbcd5f75.js"
},
{
"name": "entries/index-server.5c83aa4e.js"
"name": "entries/index-server.f88edfa9.js"
}
]
},
Expand All @@ -39,7 +39,7 @@
"chunks": [
"chunks/server-shared-0-1.1b081f62.js",
"chunks/server-shared.fbcd5f75.js",
"entries/server.5d80c3de.js"
"entries/server.882b3b69.js"
],
"assets": [
{
Expand All @@ -49,7 +49,7 @@
"name": "chunks/server-shared.fbcd5f75.js"
},
{
"name": "entries/server.5d80c3de.js"
"name": "entries/server.882b3b69.js"
}
]
}
Expand Down Expand Up @@ -84,35 +84,35 @@
"initial": false,
"entry": false,
"recorded": false,
"id": "entries/detail-server.5d841f26.js",
"id": "entries/detail-server.b1ab83f5.js",
"size": 39218,
"hash": "",
"files": [
"entries/detail-server.5d841f26.js"
"entries/detail-server.b1ab83f5.js"
]
},
{
"rendered": false,
"initial": false,
"entry": false,
"recorded": false,
"id": "entries/index-server.5c83aa4e.js",
"id": "entries/index-server.f88edfa9.js",
"size": 39230,
"hash": "",
"files": [
"entries/index-server.5c83aa4e.js"
"entries/index-server.f88edfa9.js"
]
},
{
"rendered": false,
"initial": false,
"entry": false,
"recorded": false,
"id": "entries/server.5d80c3de.js",
"id": "entries/server.882b3b69.js",
"size": 39197,
"hash": "",
"files": [
"entries/server.5d80c3de.js"
"entries/server.882b3b69.js"
]
}
],
Expand Down Expand Up @@ -143,38 +143,38 @@
},
{
"type": "asset",
"name": "entries/detail-server.5d841f26.js",
"name": "entries/detail-server.b1ab83f5.js",
"info": {},
"size": 39218,
"emitted": false,
"comparedForEmit": false,
"cached": false,
"chunks": [
"entries/detail-server.5d841f26.js"
"entries/detail-server.b1ab83f5.js"
]
},
{
"type": "asset",
"name": "entries/index-server.5c83aa4e.js",
"name": "entries/index-server.f88edfa9.js",
"info": {},
"size": 39230,
"emitted": false,
"comparedForEmit": false,
"cached": false,
"chunks": [
"entries/index-server.5c83aa4e.js"
"entries/index-server.f88edfa9.js"
]
},
{
"type": "asset",
"name": "entries/server.5d80c3de.js",
"name": "entries/server.882b3b69.js",
"info": {},
"size": 39197,
"emitted": false,
"comparedForEmit": false,
"cached": false,
"chunks": [
"entries/server.5d80c3de.js"
"entries/server.882b3b69.js"
]
}
],
Expand All @@ -183,23 +183,23 @@
"name": "basic/multi_server_entries/input/detail.server.ts",
"id": "[project]/basic/multi_server_entries/input/detail.server.ts [server] (ecmascript)",
"chunks": [
"entries/detail-server.5d841f26.js"
"entries/detail-server.b1ab83f5.js"
],
"size": 536
},
{
"name": "basic/multi_server_entries/input/index.server.ts",
"id": "[project]/basic/multi_server_entries/input/index.server.ts [server] (ecmascript)",
"chunks": [
"entries/index-server.5c83aa4e.js"
"entries/index-server.f88edfa9.js"
],
"size": 514
},
{
"name": "basic/multi_server_entries/input/server.ts",
"id": "[project]/basic/multi_server_entries/input/server.ts [server] (ecmascript)",
"chunks": [
"entries/server.5d80c3de.js"
"entries/server.882b3b69.js"
],
"size": 511
},
Expand Down
6 changes: 3 additions & 3 deletions .../output/server/entries/server.6de379ea.js → .../output/server/entries/server.ae483216.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...put/server/entries/server.6de379ea.js.map → ...put/server/entries/server.ae483216.js.map
View file
Open in desktop
File renamed without changes.
Loading
Loading