Skip to content

pdf-import: use a file:// URL for the pdf.js worker (fixes jdf convert on Windows) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EienMosu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pdf-import: use a file:// URL for the pdf.js worker (fixes jdf convert on Windows) #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/jdf-pdf-import/src/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ async function loadNodePdfJs() {
}
const workerPath = require_.resolve("pdfjs-dist/build/pdf.worker.mjs");
if (lib.GlobalWorkerOptions) {
lib.GlobalWorkerOptions.workerSrc = workerPath;
// The fake worker `import()`s this string. Node's ESM loader rejects
// bare absolute paths on Windows ("Received protocol 'd:'"), so hand
// it a proper file:// URL on every platform.
const { pathToFileURL } = await import("node:url");
lib.GlobalWorkerOptions.workerSrc = pathToFileURL(workerPath).href;
}
// Sibling asset directories shipped in the pdfjs-dist package.
const { dirname, join } = await import("node:path");
Expand Down