fix: GNU-compatible month/year overflow instead of clamping#254
Closed
ChrisDryden wants to merge 1 commit into
Closed
fix: GNU-compatible month/year overflow instead of clamping#254ChrisDryden wants to merge 1 commit into
ChrisDryden wants to merge 1 commit into
Conversation
ChrisDryden
force-pushed
the
gnu-month-year-overflow
branch
from
39a2e23 to
d9edacd
Compare
Contributor
Author
|
Didn't realize there was already another similar PR: #253 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corresponds to the two date integration tests: rel-2b and leap-1. The original integration tests were checking for the wrong date when compared to the GNU date implementation. A more in depth explanation of the issue is here: uutils/coreutils#10242