Skip to content

fix: resolve security issues - #8

Merged
v81d merged 7 commits into
mainfrom
fix/security-improvements
Aug 23, 2026
Merged

v81d merged 7 commits into
mainfrom
fix/security-improvements

Conversation

@v81d

@v81d v81d commented Jul 24, 2026

Copy link
Copy Markdown
Owner

This PR adds the following fixes regarding user security and privacy:

  • Commands were previously read directly as arguments, meaning anyone could see the full process directly via the ps command at the right moment. This can leak data if the inputted command contained secrets. Reading from stdin will prevent the command from appearing in the process list. (All shell hooks now pipe the to-be-checked command directly instead of passing it as an argument.)
  • Implemented a warning when adding regrets to make sure the user did not submit a command containing secrets.

v81d added 2 commits July 18, 2026 10:34
… args

Commands were previously read directly as arguments, meaning anyone
could see the full process directly via the ps command at the right
moment. This can leak data if the inputted command contained secrets.
Reading from stdin will prevent the command from appearing in the
process list.

(All shell hooks now pipe the to-be-checked command directly instead of
passing it as an argument.)
@v81d v81d added this to the 0.4.0 milestone Jul 24, 2026
@v81d v81d self-assigned this Jul 24, 2026
@v81d v81d added the enhancement New feature or request label Jul 24, 2026
@v81d v81d modified the milestones: 0.4.0, 0.3.1 Aug 23, 2026
@v81d
v81d force-pushed the fix/security-improvements branch from 0ce5b2f to 7737365 Compare August 23, 2026 19:27
@v81d

v81d commented Aug 23, 2026 •

Copy link
Copy Markdown
Owner Author

Possible (future) improvements (v0.4.0?):

  • Perhaps make the regret-adding process interactive and (somehow) erase each prompt after submission to prevent sensitive info from lingering in the terminal session.
  • Add regex or glob support so its way more flexible.

@v81d
v81d merged commit 4e9c96d into main Aug 23, 2026
6 checks passed
@v81d
v81d deleted the fix/security-improvements branch August 23, 2026 19:41
v81d added a commit that referenced this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant