refactor!: apply width: 100% and remove flex value in grid#11416
Open
DiegoCardoso wants to merge 2 commits intomainfrom
Open
refactor!: apply width: 100% and remove flex value in grid#11416DiegoCardoso wants to merge 2 commits intomainfrom
width: 100% and remove flex value in grid#11416DiegoCardoso wants to merge 2 commits intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
flex: 1 1auto from grid's:hoststyles (both base and Lumo), replacing it withwidth: 100%. The browser default flex: 0 1 autonow applies.flex-grow: 0andwidth: 100%overrides from :host([all-rows-visible])since the defaults already provide this behavior.Fixes #11376
Why
flex: 1 1 autoon:hostcausesflex-grow: 1, making the grid expand to fill any space in a flex container. This overrides explicit heights set by developers.Behavioral changes
all-rows-visiblegridBreaking change
Grids that previously relied on
flex-grow: 1to automatically fill vertical flex containers will no longer do so. Developers who want the old behavior can addflex-grow: 1to the grid explicitly.Testing
I asked Claude to generate a page with some testing scenarios placing a grid alone or with siblings in different containers. The only ones I found some difference are when a grid is added next to a sibling with defined width in a flex container (in the example, it uses a
horizontal-layoutas parent):Before
After
The testing page can be checked here: grid-sizing.html
Type of change