Add generic vacanza.py script for exporting holiday calendars#3257
Add generic vacanza.py script for exporting holiday calendars#3257sinhaanushka wants to merge 5 commits intovacanza:devfrom
Conversation
|
Caution Review failedFailed to post review comments Summary by CodeRabbit
WalkthroughAdds a new example script Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
I’ve addressed the CI issues by removing print statements, fixing formatting, and adding the required license header. I’ve also pushed an update to re-trigger the checks. Please let me know if there’s anything else I should adjust. Thanks! |
|
Hi @arkid15r and @KJhellico 👋 I noticed that PR #3257 was opened a few weeks ago for this, but it seems to be stalled. The automated review also noted that it's currently missing the core requirements discussed here: command-line argument support (country code, year ranges) and the --public-only filtering. If the current author is no longer working on it, I would love to be assigned to this issue. I can open a fresh PR that cleanly implements the examples/vacanza.py script with all the requested CLI features and passing checks. Let me know if I can go ahead! |



Proposed change
This PR adds a generic example script 'vacanza.py' under the 'examples' directory.
The script demonstrates how to:
This serves as a reusable helper for future CLI or automation workflows.
My PR link : #3257
Fixes #3189
Type of change
-[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Checklist