Skip to content

Update United States holidays: add Good Friday, Christmas Eve, New Year's Eve to UNOFFICIAL category #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PPsyrius wants to merge 5 commits into
base: dev
Choose a base branch
from
+24,214 −2,437
Open

Update United States holidays: add Good Friday, Christmas Eve, New Year's Eve to UNOFFICIAL category #3324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a92fe9c
Update United States holidays: add Good Friday, Christmas Eve, New Ye…
PPsyrius Mar 12, 2026
32c4a10
Update United States holidays: add Easter Sunday to `UNOFFICIAL` cate…
PPsyrius Mar 14, 2026
4b1b8d6
`test_lee_jackson_day` update
PPsyrius Mar 14, 2026
b59f942
Merge branch 'dev' into US_unofficial
PPsyrius Mar 17, 2026
5d6ec27
Increment l10n version number
PPsyrius Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions holidays/countries/united_states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,6 +1583,15 @@ def _populate_unofficial_holidays(self):
# Saint Patrick's Day.
self._add_saint_patricks_day(tr("Saint Patrick's Day"))

# Easter Holidays.
# Observed informally across the US.

# Good Friday.
self._add_good_friday(tr("Good Friday"))

# Easter Sunday.
self._add_easter_sunday(tr("Easter Sunday"))

# Mother's Day.
# Starts to be observed by most US states by 1911.
# Officially proclaimed as a National Holiday by President Woodrow Wilson in 1914.
Expand All @@ -1605,6 +1614,15 @@ def _populate_unofficial_holidays(self):
# Halloween.
self._add_holiday_oct_31(tr("Halloween"))

# While earlier observance existed at local levels, Christmas Day and New Year's Day
# were not established as federal holidays until June 28, 1870.
if self._year >= 1870:
# Christmas Eve.
self._add_christmas_eve(tr("Christmas Eve"))

# New Year's Eve.
self._add_new_years_eve(tr("New Year's Eve"))

# Continental US non-Public dates

if self.subdiv not in {"AS", "GU", "MP", "PR", "UM", "VI"}:
Expand Down
12 changes: 8 additions & 4 deletions holidays/locale/en_US/LC_MESSAGES/US.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
#
msgid ""
msgstr ""
"Project-Id-Version: Holidays 0.88\n"
"Project-Id-Version: Holidays 0.94\n"
"Report-Msgid-Bugs-To: l10n@vacanza.dev\n"
"POT-Creation-Date: 2025-06-19 15:33+0700\n"
"PO-Revision-Date: 2025-12-23 10:55-0800\n"
"Last-Translator: ~Jhellico <jhellico@gmail.com>\n"
"PO-Revision-Date: 2026-03-14 17:16+0700\n"
"Last-Translator: PPsyrius <ppsyrius@ppsyrius.dev>\n"
"Language-Team: Holidays Localization Team\n"
"Language: en_US\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Generated-By: Lingva 5.0.6\n"
"X-Generator: Poedit 3.8\n"
"X-Generator: Poedit 3.9\n"
"X-Source-Language: en_US\n"

#. %s (observed).
Expand Down Expand Up @@ -496,6 +496,10 @@ msgstr ""
msgid "Saint Patrick's Day"
msgstr ""

#. Easter Sunday.
msgid "Easter Sunday"
msgstr ""

#. Mother's Day.
msgid "Mother's Day"
msgstr ""
Expand Down
10 changes: 7 additions & 3 deletions holidays/locale/th/LC_MESSAGES/US.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
#
msgid ""
msgstr ""
"Project-Id-Version: Holidays 0.88\n"
"Project-Id-Version: Holidays 0.94\n"
"Report-Msgid-Bugs-To: l10n@vacanza.dev\n"
"POT-Creation-Date: 2025-06-19 15:33+0700\n"
"PO-Revision-Date: 2025-12-23 10:55-0800\n"
"PO-Revision-Date: 2026-03-14 17:16+0700\n"
"Last-Translator: PPsyrius <ppsyrius@ppsyrius.dev>\n"
"Language-Team: Holidays Localization Team\n"
"Language: th\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Generated-By: Lingva 5.0.6\n"
"X-Generator: Poedit 3.8\n"
"X-Generator: Poedit 3.9\n"
"X-Source-Language: en_US\n"

#. %s (observed).
Expand Down Expand Up @@ -496,6 +496,10 @@ msgstr "วันวาเลนไทน์"
msgid "Saint Patrick's Day"
msgstr "วันนักบุญแพทริก"

#. Easter Sunday.
msgid "Easter Sunday"
msgstr "วันอาทิตย์อีสเตอร์"

#. Mother's Day.
msgid "Mother's Day"
msgstr "วันแม่"
Expand Down
Loading
Loading