Skip to content

Refactor RedirectService::addRedirect()#10

Open
mmikkel wants to merge 1 commit into
masterfrom
feature/refactor-add-redirect
Open

Refactor RedirectService::addRedirect()#10
mmikkel wants to merge 1 commit into
masterfrom
feature/refactor-add-redirect

Conversation

@mmikkel
Copy link
Copy Markdown
Member

@mmikkel mmikkel commented Mar 3, 2024

Refactors how existing redirects are handled when adding new redirects (or editing existing ones):

  • Existing redirects are never updated, only deleted, if the redirect being added (or edited) has the same siteId (or a null siteId) as the existing one
  • If an existing redirect has the same sourceUrl, but a different siteId from the redirect being saved, it's left alone
  • In querying for existing or conflicting redirects when saving an edited redirect, the id param is added to the queries

This solves some unexpected behaviours when adding new redirects or editing existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant