Skip to content

chore(desktop): Developer ID signing + notarization #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vakovalskii merged 1 commit into from
Jul 20, 2026
Merged

chore(desktop): Developer ID signing + notarization #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
}
],
"icon": "build/icon.png",
"identity": "Valeriy Kovalsky (A933C2TJXU)",
"hardenedRuntime": true,
"gatekeeperAssess": false,
"entitlements": "build/entitlements.mac.plist",
Expand Down
41 changes: 26 additions & 15 deletions desktop/scripts/notarize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
// electron-builder afterSign hook — notarizes the signed .app with Apple.
//
// It runs automatically after signing during `electron-builder --mac`. It is a
// no-op unless the three Apple env vars are set, so an unsigned/local build
// still succeeds:
// no-op unless notarization credentials are provided, so an unsigned/local
// build still succeeds. Two credential modes are supported:
//
// APPLE_ID your Apple ID email
// APPLE_APP_SPECIFIC_PASSWORD app-specific password (appleid.apple.com → Sign-In & Security)
// APPLE_TEAM_ID your 10-char Developer Team ID
// 1. Keychain profile (preferred — no secret in env/transcript):
// APPLE_KEYCHAIN_PROFILE name of a profile stored via
// `xcrun notarytool store-credentials <name>`
//
// 2. Explicit env vars (e.g. for CI):
// APPLE_ID your Apple ID email
// APPLE_APP_SPECIFIC_PASSWORD app-specific password (appleid.apple.com)
// APPLE_TEAM_ID your 10-char Developer Team ID
//
// Signing itself is handled by electron-builder when a "Developer ID Application"
// cert is available (in the login keychain, or via CSC_LINK + CSC_KEY_PASSWORD).
Expand All @@ -18,9 +23,21 @@ exports.default = async function notarizing(context) {
const { electronPlatformName, appOutDir } = context;
if (electronPlatformName !== 'darwin') return;

const { APPLE_ID, APPLE_APP_SPECIFIC_PASSWORD, APPLE_TEAM_ID } = process.env;
if (!APPLE_ID || !APPLE_APP_SPECIFIC_PASSWORD || !APPLE_TEAM_ID) {
console.log('[notarize] skipped — set APPLE_ID / APPLE_APP_SPECIFIC_PASSWORD / APPLE_TEAM_ID to enable.');
const { APPLE_KEYCHAIN_PROFILE, APPLE_ID, APPLE_APP_SPECIFIC_PASSWORD, APPLE_TEAM_ID } = process.env;

let creds;
if (APPLE_KEYCHAIN_PROFILE) {
creds = { tool: 'notarytool', keychainProfile: APPLE_KEYCHAIN_PROFILE };
} else if (APPLE_ID && APPLE_APP_SPECIFIC_PASSWORD && APPLE_TEAM_ID) {
creds = {
tool: 'notarytool',
appleId: APPLE_ID,
appleIdPassword: APPLE_APP_SPECIFIC_PASSWORD,
teamId: APPLE_TEAM_ID,
};
} else {
console.log('[notarize] skipped — set APPLE_KEYCHAIN_PROFILE (preferred) or ' +
'APPLE_ID / APPLE_APP_SPECIFIC_PASSWORD / APPLE_TEAM_ID to enable.');
return;
}

Expand All @@ -36,13 +53,7 @@ exports.default = async function notarizing(context) {
const appPath = path.join(appOutDir, appName + '.app');
console.log('[notarize] submitting ' + appName + '.app to Apple (this can take a few minutes)…');

await notarize({
tool: 'notarytool',
appPath: appPath,
appleId: APPLE_ID,
appleIdPassword: APPLE_APP_SPECIFIC_PASSWORD,
teamId: APPLE_TEAM_ID,
});
await notarize(Object.assign({ appPath: appPath }, creds));

console.log('[notarize] done — ' + appName + '.app is notarized.');
};
Loading