Skip to content

add fasttext jpn language model - #1

Open
wvanamstel wants to merge 3 commits into
vampolo:masterfrom
wvanamstel:master
Open

add fasttext jpn language model#1
wvanamstel wants to merge 3 commits into
vampolo:masterfrom
wvanamstel:master

Conversation

@wvanamstel

Copy link
Copy Markdown

Added fasttext Japanese language model in its own directory. Renamed the original w2v src directory. To be done: change Dockerfile to reflect these changes.

@vampolo

vampolo commented Feb 21, 2018

Copy link
Copy Markdown
Owner

Hey @wvanamstel, thanks for the contribuition.
I think we should make a stronger folder change here. What I mean is to have 2 folders in the root: word2vec and fasttext. Each of those have their entrypoint.sh and src folder with the relevant changes.
Do you think you can make those changes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants