Repository navigation
feat: Add an option to show the title and author in a page header, plus optional separator - #390
Merged
Merged
Conversation
…ption to draw a separator between the header/footer and the page.
Owner
|
@RobinD42, I noticed |
Contributor
Author
|
Okay, I'll work on that when I switch back to the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Contributor checklist
Summary
Add per-library Show header and Show header/footer borders options for EPUB, PDF, and comic readers. Both are off by default. The optional header places the title on the left and author on the right, truncating the title only when it would overlap the author. Thin, screen-wide borders optionally appear below the header and above an enabled progress footer.
Header positioning uses the viewport’s on-screen location, status-bar inset, and visible display frame to avoid status-bar overlap across devices. Preference and positioning regression tests, translated settings strings, and the UI/UX documentation are included.
Verification
.\gradlew.bat :app:compileDebugKotlin :app:testDebugUnitTest :app:lintDebug :app:assembleDebug— passed.git diff --check— passed.NOTE: It appears that for PDF and Comics that the page view always starts at the top of the screen, regardless of whether the status bar (and now the header) is hidden or not. I expect it's the same with EPUB but the larger default top margin prevents that from being obvious. I didn't try changing it in this PR in case there is a good reason for it to be this way. I can attempt it another time if you want. IMO, it would be nice if the top of the page behaved more like the bottom does with the navbar and/or progress info.
BTW: Feel free to change things in my PRs if you want, or to request changes.
Screenshots