Skip to content

feat: Add an option to show the title and author in a page header, plus optional separator - #390

Merged
van-geaux merged 2 commits into
van-geaux:mainfrom
RobinD42:feat/add-title-header
Nov 3, 2026
Merged

van-geaux merged 2 commits into
van-geaux:mainfrom
RobinD42:feat/add-title-header

Conversation

@RobinD42

@RobinD42 RobinD42 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Pull request

Contributor checklist

  • The change is scoped to the related issue or feature discussion.
  • Tests and manual-validation status are documented.
  • No credentials, cookies, API keys, private server URLs, or generated local data are included.

Summary

Add per-library Show header and Show header/footer borders options for EPUB, PDF, and comic readers. Both are off by default. The optional header places the title on the left and author on the right, truncating the title only when it would overlap the author. Thin, screen-wide borders optionally appear below the header and above an enabled progress footer.

Header positioning uses the viewport’s on-screen location, status-bar inset, and visible display frame to avoid status-bar overlap across devices. Preference and positioning regression tests, translated settings strings, and the UI/UX documentation are included.

Verification

  • .\gradlew.bat :app:compileDebugKotlin :app:testDebugUnitTest :app:lintDebug :app:assembleDebug — passed.
  • git diff --check — passed.
  • Manual validation on 3 physical devices with and without cut outs, plus the emulator. I iterated with the AI until it worked correctly in all cases I was testing, with and without the status bar.

NOTE: It appears that for PDF and Comics that the page view always starts at the top of the screen, regardless of whether the status bar (and now the header) is hidden or not. I expect it's the same with EPUB but the larger default top margin prevents that from being obvious. I didn't try changing it in this PR in case there is a good reason for it to be this way. I can attempt it another time if you want. IMO, it would be nice if the top of the page behaved more like the bottom does with the navbar and/or progress info.

BTW: Feel free to change things in my PRs if you want, or to request changes.

Screenshots

Screenshot_20261101_194956_Lagrange

Screenshot_20261101_195043_Lagrange

Screenshot_20261101_195122_Lagrange

…ption to draw a separator between the header/footer and the page.
@van-geaux

Copy link
Copy Markdown
Owner

@RobinD42, I noticed readerContainer reserves space for the footer but not the header, while headerView is added as an overlay. Since PDF and comic pages start at the top, the header may cover page content when enabled. Could you confirm whether you see this on your devices too? If so, please reserve space for the header while keeping the current layout when it’s off. Thanks!

@RobinD42

RobinD42 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I'll work on that when I switch back to the branch.

@van-geaux van-geaux left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobinD42, thanks for the update. I reviewed the latest changes and found no blocking issues. The PR looks ready to merge. Thanks for your work on this!

@van-geaux
van-geaux merged commit a7f98fc into van-geaux:main Nov 3, 2026
1 check passed
@RobinD42
RobinD42 deleted the feat/add-title-header branch November 4, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants