Repository navigation
fix: The chapter popup now opens with the selected item scrolled into view - #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
The user may have to scroll a long ways to see the current chapter in the popup chapters list. Although there may be times you want to see the top of the list, I think it's easier to get back to the top than it is to search for the current chapter.
Contributor checklist
Summary
The reader’s chapter/page popup now opens with the selected item in view.
Verification
.\gradlew.bat :app:testDebugUnitTest --tests com.vangeaux.lagrange.ReaderChromePositionStateTest— passed..\gradlew.bat :app:lintDebug :app:assembleDebug— passed.git diff --check upstream/main...HEAD— passed.Manually verified on 2 devices