Repository navigation
Conversation
…book, so the just read book stays at the head of the list.
|
@RobinD42, I think the optimistic progress can still disappear too soon. The coordinator loads the Home shelves, then refreshes the catalog. If the catalog has the new We’ll take a few days to test this behavior before deciding on next steps. Thanks for your work on this! |
|
Yep, I did notice that 2 books (at the 4th and 5th positions IIRC) sometimes still swapped places after my change. I investigated a little with Copilot but didn't do any other changes related to it as I wasn't sure I understood how it is supposed to work. Maybe the catalog should just always be updated to match BookOrbit's Currently Reading order? Anyway, here is the Copilot question and response in case it helps you:
|
Pull request
I noticed that after reading a book it would momentarily shift to the left side of the Currently reading shelf on Home, and then shift back to where it was. It seems it was refreshing to the old last-read value from BookOrbit instead of waiting until BookOrbit is fully updated with the new status.
Contributor checklist
Summary
Keep a book’s optimistic
lastReadAtMillisupdate after reading until refreshed server data reflects it. A successful progress sync may precede the catalog endpoint showing the updated timestamp, which could otherwise move the book back down the Currently reading shelf.Adds coordinator regression coverage for both stale catalog responses and server data that has caught up.
Verification
.\gradlew.bat :app:testDebugUnitTest— passed.git diff --check— passed.