Added pop-off and corrected little issues - #4
Open
albyfil88 wants to merge 1 commit into
Open
Conversation
- Corrected streaming data's format in readme file: from this: (mapCorrected,vntTargetPressure,vntPositionRemapped,tpsCorrected,rpmActual,pidOutput,n75precontrol,vntMinDc,vntMaxDc,mode,targetRatioKp,targetRatioKi,targetRatioKd,boostCalculatedP,boostCalculatedI,boostCalculatedD,temp1,auxOutput,millis( / 10)) to this: (mapCorrected,vntTargetPressure,vntPositionRemapped,tpsCorrected,rpmActual,temp1,boostCalculatedP,boostCalculatedI,boostCalculatedD,pidOutput,n75precontrol,vntMinDc,vntMaxDc,rpmCorrected,mode,auxOutput,millis( / 10)) - Added pop-off to sketch: The pop-off follows this logic: when I exceed a certain TPS value, the pop-off system is armed. If I drop below a certain TPS value, within a certain time limit, at a certain minimum MAP value, the pop-off (output #10) is activated for a certain amount of time. All the times and values is configurable in sketch. I tried my best to integrate everything into the code as best as possible. I'm not an Arduino code expert, so I used AI to generate the code and figure out where to insert it best. I'd be very happy if you could check and confirm that everything is OK. You can easily find the parts I added because they are delimited by this: "//POP_OFF". The pop-off in a diesel engine is usually unnecessary, but it could be an interesting addition if you happen to have problems with turbo surging, fluttering, or simply if you want a cool pop-off in your diesel car!
|
how do I configure everything to work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from this:
mapCorrected,vntTargetPressure,vntPositionRemapped,tpsCorrected,rpmActual,pidOutput,n75precontrol,vntMinDc,vntMaxDc,mode,targetRatioKp,targetRatioKi,targetRatioKd,boostCalculatedP,boostCalculatedI,boostCalculatedD,temp1,auxOutput,millis( / 10)
to this:
mapCorrected,vntTargetPressure,vntPositionRemapped,tpsCorrected,rpmActual,temp1,boostCalculatedP,boostCalculatedI,boostCalculatedD,pidOutput,n75precontrol,vntMinDc,vntMaxDc,rpmCorrected,mode,auxOutput,millis( / 10)
PS: 1 million of times thanks to you and the original author for this fantastic project!