Skip to content

Polygon: boxes with bottom or right side of exactly zero are not in the box #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vancluever merged 1 commit into from
Sep 2, 2026
Merged

Polygon: boxes with bottom or right side of exactly zero are not in the box #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/internal/tess/Polygon.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ pub fn inBox(self: *const Polygon, scale: f64, box_width: i32, box_height: i32)

// Fast-path negative bottom or right side - if either of these are true,
// then there's no chance we're in the box.
if (self.extent_right < 0.0 or self.extent_bottom < 0.0 ) {
if (self.extent_right <= 0.0 or self.extent_bottom <= 0.0) {
return false;
}

Expand Down Expand Up @@ -706,6 +706,32 @@ test "Polygon.inBox" {
.box_width = 10,
.expected = false,
},
.{
.name = "OOB, bottom adjacent at exactly zero",
.polygon = .{
.extent_left = -37.0,
.extent_top = -29.0,
.extent_right = 21.0,
.extent_bottom = 0.0,
},
.scale = 1.0,
.box_height = 100,
.box_width = 100,
.expected = false,
},
.{
.name = "OOB, right side adjacent at exactly zero",
.polygon = .{
.extent_left = -37.0,
.extent_top = -29.0,
.extent_right = 0.0,
.extent_bottom = 21.0,
},
.scale = 1.0,
.box_height = 100,
.box_width = 100,
.expected = false,
},
.{
.name = "scale",
.polygon = .{
Expand Down
Loading