Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: weekly
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,16 @@ jobs:
- id: kendex
if: steps.render-reach.outputs.render_candidate == 'true'
continue-on-error: true
timeout-minutes: 3
shell: bash
Comment thread
bmethod marked this conversation as resolved.
env:
GH_TOKEN: ""
GITHUB_TOKEN: ${{ github.token }}
run: classifier/.agents/skills/review-gate/scripts/install-latest.sh
- id: mirror
if: steps.render-reach.outputs.render_candidate == 'true'
continue-on-error: true
timeout-minutes: 5
run: kendex source refresh
working-directory: subject
- name: Report unavailable render prerequisites
Expand Down Expand Up @@ -132,7 +135,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: .bun-version
- name: Check the application
Expand Down Expand Up @@ -301,7 +304,7 @@ jobs:
--results "$NEEDS" --classifier changes \
--waiver "$WAIVER" --skippable application \
--lane application=application "${package[@]}"
- name: Scan the pull request's commits for credentials
- name: secrets (credential scan of the pull request diff)
if: always() && github.event_name == 'pull_request'
working-directory: subject
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
with:
ref: ${{ env.TAG }}
persist-credentials: false
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0
with:
bun-version-file: .bun-version
# Setting the version is a manual step of the release procedure in
Expand Down
9 changes: 9 additions & 0 deletions scripts/ci_workflow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ def check_wiring(self, workflow):
self.assertEqual(shlex.split(command(self.step(changes, header)))[0], executable)
for header in ("id: kendex", "id: mirror"):
self.assertEqual(scalar(self.step(changes, header), "if"), "steps.render-reach.outputs.render_candidate == 'true'")
# Unbounded, a hung install or refresh runs to the job's timeout and
# fails the whole changes job, where continue-on-error would have let
# the classifier run on.
kendex = self.step(changes, "id: kendex")
self.assertEqual((scalar(kendex, "timeout-minutes"), scalar(kendex, "shell")), ("3", "bash"))
self.assertEqual(scalar(self.step(changes, "id: mirror"), "timeout-minutes"), "5")
classify = self.step(changes, "id: classify")
self.assertEqual(scalar(classify, "uses"), ACTION)
# The lane declaration comes from the default branch's checkout, and
Expand All @@ -274,6 +280,9 @@ def test_classifier_and_render_prerequisites_use_the_trusted_checkout(self):
("covers-all-lanes", " lanes-from: classifier\n", " lanes-from: classifier\n covers-all-lanes: true\n"),
("lanes-from-subject", "lanes-from: classifier", "lanes-from: subject"),
("render-reach-subject", "classifier/.agents/skills/harness-ci/scripts/harness-only", "subject/.agents/skills/harness-ci/scripts/harness-only"),
("kendex-timeout", " timeout-minutes: 3\n", " timeout-minutes: 30\n"),
("kendex-shell", " shell: bash\n", " shell: sh\n"),
("mirror-timeout", " timeout-minutes: 5\n run: kendex source refresh\n", " timeout-minutes: 50\n run: kendex source refresh\n"),
)
for control, old, new in controls:
with self.subTest(control=control):
Expand Down
Loading