docs: use the colour Vantage SVG as the navbar logo - #6
Merged
Merged
Conversation
The navbar mark was a PNG fetched from the S3 branding bucket on every page load, and its href pointed back at this site's own root, so clicking the logo went nowhere. Serve the SVG from static/img instead and send the click to the docs hub at https://docs.vantagecompute.ai. No srcDark: the theme pins the navbar background to #18123B in both colour modes, so the wordmark's white glyphs read identically either way. Verified by building the site and reading build/index.html: the brand anchor carries href="https://docs.vantagecompute.ai" and both themed <img> tags point at /developer/armasec-lite/img/vantage-logo-color.svg. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the navbar logo with the colour Vantage SVG served from the site's own
static/img/, and points the logo's click target at the docs hub.docusaurus/static/img/vantage-logo-color.svg— new, 4.4K, 175x40 viewBox.docusaurus/docusaurus.config.ts—navbar.logonowsrc: 'img/vantage-logo-color.svg',href: 'https://docs.vantagecompute.ai',target: '_self'.Why
Two problems with the old configuration:
header waited on a third-party request and the raster blurred at high zoom.
hrefwashttps://docs.vantagecompute.ai/developer/armasec-lite/, this site'sown root, so clicking the logo from any page other than the landing page navigated
back to the landing page rather than out to the hub.
srcDarkis deliberately gone rather than duplicated. The theme pins--vantage-navbar-bgto#18123Bin both colour modes, and the wordmark's glyphs arefill="white", so a single asset reads identically in light and dark. A second filewould only be a second thing to keep in sync.
Verification
npm run buildindocusaurus/succeeds (14 pydoc modules, 33 documents). Reading thebuilt output rather than trusting the build's exit code:
build/img/vantage-logo-color.svgis present.build/index.htmlrenders the brand anchor as<a href="https://docs.vantagecompute.ai" target="_self" rel="noopener noreferrer" class="navbar__brand">.<img>tags point at/developer/armasec-lite/img/vantage-logo-color.svg.Note, unchanged by this PR
The theme's CSS hides
.navbar__logobelow 1024px(
--vantage-navbar-logo-hide-bp), so on narrow viewports there is no logo and thereforeno hub link. That is pre-existing behaviour, not something this change introduces.
🤖 Generated with Claude Code