Take the brand mark from the shared theme, refresh docs deps, pin actions - #9
Merged
Merged
Conversation
… deps The navbar and footer logo definitions now come from @vantagecompute/docusaurus-theme 0.4.7, which exports navbarLogo and footerLogo and ships the SVG in its own static directory. This site already added the package's staticDir to staticDirectories, so the asset resolves with no local copy. The footer had been left on an S3-hosted PNG while the navbar used a local SVG, so the two marks did not match each other; both now come from one place. Also moves the docusaurus family to 3.10.2 and react to 19.2.8. Builds clean with no warnings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01217GwqZQz23PJY3hbMH9Bp
A tag is mutable: whoever owns the action can repoint it at new code, and this workflow then runs it. A sha cannot be repointed, so the version comment beside it is the only part that has to stay readable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01217GwqZQz23PJY3hbMH9Bp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar and footer logo definitions now come from
@vantagecompute/docusaurus-theme0.4.7, which exportsnavbarLogoandfooterLogoand ships the SVG in its own static directory. This site already added the package'sstaticDirtostaticDirectories, so the asset resolves with no local copy and the duplicated SVG goes away.The footer had been left on an S3-hosted PNG while the navbar used a local SVG, so the two marks did not match each other. Both now come from one place.
Also moves the docusaurus family to 3.10.2 and react to 19.2.8, and pins the workflow's action to the commit SHA of its current release rather than a mutable tag.
yarn buildsucceeds with no warnings at all.Part of a fleet-wide pass: eight other Vantage docs sites take the same mark from the same package.
🤖 Generated with Claude Code
https://claude.ai/code/session_01217GwqZQz23PJY3hbMH9Bp