fix(shim): Enforce HookOnlyStrategy for Helm upgrades - #18
Merged
Merged
Conversation
This commit modifies the Helm upgrade logic in the Go shim to explicitly use the `HookOnlyStrategy` when waiting for operations to complete. This ensures that upgrades only wait for pre/post-upgrade hooks to finish, rather than blocking until all resources in the release are fully ready, which helps prevent timeouts on complex stateful workloads. * **Upgrade Strategy**: The `helm_sdkpy_upgrade` function now sets `client.WaitStrategy = kube.HookOnlyStrategy`. * **Formatting**: Applied minor whitespace and formatting fixes throughout `go/shim/main.go` to align variable declarations and comments.
matheushent
force-pushed
the
fix-upgrade
branch
from
December 9, 2025 12:53
f333870 to
05f5a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the Helm upgrade logic in the Go shim to explicitly use the
HookOnlyStrategywhen waiting for operations to complete. This ensures that upgrades only wait for pre/post-upgrade hooks to finish, rather than blocking until all resources in the release are fully ready, which helps prevent timeouts on complex stateful workloads.helm_sdkpy_upgradefunction now setsclient.WaitStrategy = kube.HookOnlyStrategy.go/shim/main.goto align variable declarations and comments.