fix: the public navbar shows no version badge - #12
Merged
Merged
Conversation
0.5.0 kept the lone centred badge the main docs site used to render when its navbar had no title. The public navbar is meant to be logo-only: the brand mark, search, the SiteActions slot and the toggle. The badge, like the title, now belongs to the developer variant alone, and the CSS that existed only to hide a lone badge on tablets goes with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.5.0 carried over the lone centred version badge the main docs site used to render when its navbar had no title. Bryan's call: the public navbar is logo-only. The version badge, like the centred title, now renders on the developer variant only, and
customFields.projectVersionis ignored on the public one.useVantageNavbarreturnsversion: nullunless the variant is developer.Verified
baseUrl: '/': nonavbar__version-badge, nonavbar__center-titleelement, brand link to the docs root.After merge
Release as 0.5.1. Spokes are unaffected (developer variant); the one site that changes is vantage-docs, whose open PR (vantagecompute/vantage-docs#142) locks 0.5.0 and needs its lockfile moved to 0.5.1 once published.
🤖 Generated with Claude Code