Add code to auto-detect device if device is not provided #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
raffeyC
commented
Dec 17, 2024
raffeyC
commented
- Needs testing with MPS devices
- Added commented code for using bfloat16, but slower inference and fails when converting to numpy, so ignore until necessary
Prevent issues on macos CI.
rossbar
reviewed
Jan 23, 2025
|
|
||
| self.device = device | ||
| self.model = model | ||
| self.model = model.to(self.device) |
Contributor
There was a problem hiding this comment.
Do we want to add a model.eval() after this line?
Contributor
|
I'll go ahead and get this in now anyways, questions about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.