Skip to content

Remove NSString API usage - #243

Merged
ptoffy merged 2 commits into
vapor:mainfrom
Cyberbeni:patch-1
Apr 28, 2026
Merged

Remove NSString API usage#243
ptoffy merged 2 commits into
vapor:mainfrom
Cyberbeni:patch-1

Conversation

@Cyberbeni

@Cyberbeni Cyberbeni commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

These changes are now available in 5.4.1

resolves #242

Remove NSString API usage

@ptoffy ptoffy added the semver-patch Internal changes only label Apr 28, 2026
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.19%. Comparing base (aa60a21) to head (a8928c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   82.21%   82.19%   -0.02%     
==========================================
  Files          61       61              
  Lines        1456     1455       -1     
==========================================
- Hits         1197     1196       -1     
  Misses        259      259              
Files with missing lines Coverage Δ
Sources/JWTKit/Utilities/Base64URL.swift 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptoffy ptoffy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this won't work in iOS 15. We have a native base64URL unescaping function already, let's use it

extension String {
    package func base64URLDecodedData() -> Data? {
        var data = Data(self.utf8)
        data.base64URLUnescape()
        return Data(base64Encoded: data)
    }
}

@Cyberbeni
Cyberbeni requested a review from ptoffy April 28, 2026 13:22
@ptoffy
ptoffy merged commit 94a8b96 into vapor:main Apr 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Internal changes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove NSString API usage

2 participants