Remove NSString API usage - #243
Merged
Merged
Conversation
ptoffy
approved these changes
Apr 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 82.21% 82.19% -0.02%
==========================================
Files 61 61
Lines 1456 1455 -1
==========================================
- Hits 1197 1196 -1
Misses 259 259
🚀 New features to boost your workflow:
|
ptoffy
requested changes
Apr 28, 2026
Member
There was a problem hiding this comment.
Actually this won't work in iOS 15. We have a native base64URL unescaping function already, let's use it
extension String {
package func base64URLDecodedData() -> Data? {
var data = Data(self.utf8)
data.base64URLUnescape()
return Data(base64Encoded: data)
}
}
ptoffy
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 5.4.1
resolves #242
Remove NSString API usage