Skip to content

X5CVerifier: support for RSA - #244

Merged
ptoffy merged 3 commits into
vapor:mainfrom
m-barthelemy:feature/jws-rsa-support
Jun 24, 2026
Merged

X5CVerifier: support for RSA#244
ptoffy merged 3 commits into
vapor:mainfrom
m-barthelemy:feature/jws-rsa-support

Conversation

@m-barthelemy

@m-barthelemy m-barthelemy commented May 7, 2026

Copy link
Copy Markdown
Contributor

These changes are now available in 5.6.0

After #238 adding support for .es256, .es384, .es512 and .eddsa, this PR adds support for RSA signatures.

@m-barthelemy
m-barthelemy requested a review from ptoffy as a code owner May 7, 2026 14:34
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.85%. Comparing base (a93a262) to head (7e985b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   82.20%   82.85%   +0.65%     
==========================================
  Files          61       61              
  Lines        1472     1505      +33     
==========================================
+ Hits         1210     1247      +37     
+ Misses        262      258       -4     
Files with missing lines Coverage Δ
Sources/JWTKit/X5C/X5CVerifier.swift 89.25% <100.00%> (+4.02%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-barthelemy

Copy link
Copy Markdown
Contributor Author

Hi @ptoffy would you like this to be handled differently?

@ptoffy

ptoffy commented Jun 24, 2026

Copy link
Copy Markdown
Member

Hey @m-barthelemy, thanks for the ping and sorry, busy times. I'm usually quite wary about adding anything RSA related, but since we provide RSA keys already I think this addition does make sense. Thanks!

@ptoffy ptoffy added the semver-minor Contains new APIs label Jun 24, 2026
@ptoffy
ptoffy merged commit 7abc497 into vapor:main Jun 24, 2026
18 checks passed
@m-barthelemy

Copy link
Copy Markdown
Contributor Author

Hey @m-barthelemy, thanks for the ping and sorry, busy times.

No worries, busy times here too. Thanks a lot for merging this!

I'm usually quite wary about adding anything RSA related, but since we provide RSA keys already I think this addition does make sense.

I would use RSA on a new project either, in fact what made me create this PR is the Fido Metadata - they issue blobs signed using an RSA cert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor Contains new APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants