X5CVerifier: support for RSA - #244
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 82.20% 82.85% +0.65%
==========================================
Files 61 61
Lines 1472 1505 +33
==========================================
+ Hits 1210 1247 +37
+ Misses 262 258 -4
🚀 New features to boost your workflow:
|
|
Hi @ptoffy would you like this to be handled differently? |
|
Hey @m-barthelemy, thanks for the ping and sorry, busy times. I'm usually quite wary about adding anything RSA related, but since we provide RSA keys already I think this addition does make sense. Thanks! |
No worries, busy times here too. Thanks a lot for merging this!
I would use RSA on a new project either, in fact what made me create this PR is the Fido Metadata - they issue blobs signed using an RSA cert. |
These changes are now available in 5.6.0
After #238 adding support for .es256, .es384, .es512 and .eddsa, this PR adds support for RSA signatures.