Skip to content

Use comparison operator instead of compare function - #247

Merged
ptoffy merged 1 commit into
vapor:mainfrom
madrob:compare
Jul 29, 2026
Merged

Use comparison operator instead of compare function#247
ptoffy merged 1 commit into
vapor:mainfrom
madrob:compare

Conversation

@madrob

@madrob madrob commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Use modern Swift less-than operator instead of Obj-C style compare function for date check.

@madrob
madrob requested a review from ptoffy as a code owner July 28, 2026 19:22
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.98%. Comparing base (e8546f4) to head (a814a60).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/JWTKit/Claims/NotBeforeClaim.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   82.85%   82.98%   +0.13%     
==========================================
  Files          61       61              
  Lines        1505     1499       -6     
==========================================
- Hits         1247     1244       -3     
+ Misses        258      255       -3     
Files with missing lines Coverage Δ
Sources/JWTKit/Claims/ExpirationClaim.swift 100.00% <100.00%> (ø)
Sources/JWTKit/Claims/NotBeforeClaim.swift 40.00% <0.00%> (+15.00%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptoffy ptoffy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptoffy ptoffy added the no-release-needed Doesn't require a release label Jul 29, 2026
@ptoffy
ptoffy merged commit 52b598d into vapor:main Jul 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release-needed Doesn't require a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants