Repository navigation
Fix bar/menu freezing after a browser sign-in; calmer, atomic menu sync (0.5.2) - #14
Merged
Merged
Conversation
The panel is a full-screen overlay layer that holds keyboard focus. Left open during a browser sign-in, it covered the browser for the whole passkey prompt, which is when the bar and the Omarchy menu stopped responding until the shell was restarted. log in, renew and connect now close it; reopening the panel shows the sign-in under way. Device sign-in keeps the panel open, since it shows the code and QR code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The widget runs sync-menu after every status poll. The menu rows showed time left to the minute, so a live session rewrote omarchy-menu.jsonc and reloaded the menu every minute; the write was in place, so the menu could parse a half-written file, and overlapping runs could interleave writes. - Runs hold a lock, so they no longer overlap. - The menu file and state files are written to a temporary file and renamed into place (through a symlink, to its target). - servers.json is only rewritten when the servers change. - The menu counts whole hours; the panel keeps the minutes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changelog for the sign-in panel and sync-menu fixes; manifest 0.5.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On an Omarchy 4 laptop, the bar became unclickable and Super+Space stopped opening the menu, until the shell was restarted or the laptop was forced off. Both freezes in the logs happened during a browser sign-in started from the Varlatch panel:
at-spi2-registrydflagged the shell (quickshell) as unresponsive, and Hyprland logged its only-everpixman_region32_init_rect: Invalid rectangleerror seconds earlier.Changes
Browser sign-in closes the panel (
Panel.qml)Overlaylayer that holds keyboard focus. log in, renew and connect left it open over the browser for the whole passkey sign-in. They now close it throughstartBrowserLogin(). Reopening the panel still shows the sign-in under way.sync-menuchanges (bin/varlatch-menu)omarchy-menu.jsoncand reloaded the menu every minute. They now count whole hours; the panel keeps the minutes.login.json,servers.json) are written to a temporary file and renamed into place, so the shell never parses a half-written file. A symlinked menu file keeps its symlink. A writer that outputs nothing keeps the old file.flock, so overlapping runs after status polls no longer interleave their writes.servers.jsonis only rewritten when the list of servers changes, since the widget reloads it on every change.Also: README sign-in paragraph, CHANGELOG, manifest 0.5.2.
Tests
tests/run.sh: 87 passed, 0 failed locally. Five new tests cover hour-level countdowns, leavingservers.jsonalone when nothing changed, six overlappingsync-menuruns leaving one valid block, no leftover temporary files, and a symlinked menu file. shellcheck isn't installed locally, so it runs in CI only.🤖 Generated with Claude Code