test(duplicates): scale the scan time budget under the race detector - #2880
Merged
Merged
Conversation
TestScanScale asserted Scan(500 books) under 100ms, which failed on a shared runner under -race (130ms) and turned main's race (non-api) shard red at 692376c. The budget is ten times larger when the race detector is on; the normal budget is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9 Signed-off-by: vavallee <vavallee@protonmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean fix for the flaky TestScanScale failure under -race.
The //go:build race / //go:build !race pair in race_on_test.go / race_off_test.go is the standard Go stdlib idiom for this — no concerns there. The 10× multiplier is conservative but defensible for shared CI runners; the race detector typically inflates wall-clock 5–20×.
One minor note: the comment at internal/duplicates/duplicates_test.go:584 repeats the explanation already in race_on_test.go:6. Either location is fine, but both is mild duplication. Not a blocker.
— 🤖 Bindery triage bot (automated). Reply to correct me; a human will see it.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main race (non-api) failed at 692376c:
TestScanScaletook 129.99ms against a 100ms budget under-race. Adds araceEnabledbuild tag constant (test files only) and multiplies the budget by 10 when it is on. Normal runs keep 100ms.Verified:
go test -count=3andgo test -race -count=3oninternal/duplicatesboth pass.🤖 Generated with Claude Code
https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9